[Test] Use test constants to get OCP user name and password in WorkspaceIdleTimeout test #22818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkorikSergey
added
status/code-review
SkorikSergey
requested review from
musienko-maxim and
dmytro-ndp
as code owners
che-bot
added
the
target/branch
dmytro-ndp
reviewed
Feb 13, 2024
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WorkspaceIdleTimeout test works only with
adminusername. To work correcty we need to update login function to use OAUTH_CONSTANTS.TS_SELENIUM_OCP_USERNAME and OAUTH_CONSTANTS.TS_SELENIUM_OCP_PASSWORD constants.What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5738
How to test this PR?
export TS_SELENIUM_OCP_USERNAME="kubeadmin"
export TS_SELENIUM_OCP_PASSWORD="password"
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.