Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:empty attribute #22637

Closed
wants to merge 2 commits into from
Closed

fix:empty attribute #22637

wants to merge 2 commits into from

Conversation

nallikaea
Copy link
Contributor

What does this PR do?

16:23:21  URL: https://reportportal-crw.apps.ocp-c1.prod.psi.redhat.com/api/v1/devspaces/launch
16:23:21  method: POST
16:23:21      at /tmp/e2e/node_modules/@reportportal/client-javascript/lib/rest.js:41:15
16:23:21      at processTicksAndRejections (node:internal/process/task_queues:96:5)
16:23:21  Failed to send log. Error: Request failed with status code 400: {"errorCode":4001,"message":"Incorrect Request. [Field 'attributes[].value' should have size from '1' to '128'.] [Field 'attributes[].value' should not contain only white spaces and shouldn't be empty.] "}

Set default value not empty string.

Screenshot/screencast of this PR

NA

What issues does this PR fix or reference?

NA

How to test this PR?

NA

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

mdolhalo added 2 commits October 27, 2023 15:54
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master. labels Oct 27, 2023
@nallikaea nallikaea closed this Oct 27, 2023
@nallikaea
Copy link
Contributor Author

pushed into #22634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants