Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up and update 'Factory' E2E flow components #22623

Merged
merged 10 commits into from
Nov 2, 2023
Merged

Fix up and update 'Factory' E2E flow components #22623

merged 10 commits into from
Nov 2, 2023

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

  • Fixes the RefusedOAuthFactory E2E test for a factory private repository
  • Implements Bitbucket OAuth2 to the Factory test flow

Screenshot/screencast of this PR

What issues does this PR fix or reference?

#22604
#22547

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Oct 23, 2023
Copy link
Contributor

@nallikaea nallikaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Don`t forgot to squash commits =)

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@artaleks9 artaleks9 merged commit 220e13e into main Nov 2, 2023
3 checks passed
@artaleks9 artaleks9 deleted the che#22597 branch November 2, 2023 20:50
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants