-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate E2E typescript test report for ReportPortal #22590
Conversation
53b40e4
to
56b9477
Compare
bf06c39
to
3e083d8
Compare
Signed-off-by: mdolhalo <[email protected]>
3e083d8
to
d0bbcab
Compare
@nallikaea : could you please share an example of ReportPortal constants to run Dev Spaces functional test suite and send test results to ReportPortal ?:
|
docker run --shm-size=4096m -p 5920:5920 -e SAVE_RP_REPORT_DATA=true |
@nallikaea : thank you For the sake of simplicity, I would use constant The point is that when it turns to CRW Jenkins CI, |
Signed-off-by: mdolhalo <[email protected]>
okay, replaced in new commit |
/** | ||
* user name on ReportPortal | ||
*/ | ||
RP_USER: process.env.RP_USER || process.env.USER || 'superadmin', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From security perspective I would prefer empty RP user name by default.
@nallikaea : thanks for the fixup. I tried to run tests with parameters you shared [1] and using personal RP access token [2], but had got an error:
It seemed to be missing [1] #22590 (comment) |
@nallikaea : second try with RT_USER parameter and single testcase was successful: https://reportportal-crw.apps.ocp-c1.prod.psi.redhat.com/ui/#devspaces/launches/all/132 , https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/13529/console At the same time I couldn't find info about test OCP version = 4.14 and OCP infra = PSI in RP test launch.
Third run, now with |
no, you should not set RP_user by default, let me check |
e36e719
to
ec80a7b
Compare
Signed-off-by: mdolhalo <[email protected]>
ec80a7b
to
f86a542
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to merge
What does this PR do?
resolves #22543
Screenshot/screencast of this PR
https://reportportal-crw.apps.ocp-c1.prod.psi.redhat.com/ui/#devspaces/launches/all
What issues does this PR fix or reference?
resolves #22543
How to test this PR?
Use
REPORTER_CONSTANTS
to set reporter parametersThen run tests, for example using
tests/e2e/configs/sh-scripts/regressionTestRun.sh
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.