fix: make failing e2e tests to create screenshot #22536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nallikaea
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
che-bot
added
kind/bug
dkwon17
reviewed
Sep 20, 2023
tests/e2e/utils/CheReporter.ts
Outdated
|
|
||
| // take page source and write to file | ||
| const pageSource: string = await this.driverHelper.getDriver().getPageSource(); | ||
| const pageSourceStream: WriteStream = fs.createWriteStream(pageSourceFileName); | ||
| pageSourceStream.write(Buffer.from(pageSource)); | ||
| pageSourceStream.end(); | ||
| pageSourceStream.write(Buffer.from(pageSource), (): WriteStream => pageSourceStream.end()); |
There was a problem hiding this comment.
I am getting an error when I run npm run test because of WriteStream type:
Generating index.ts file...
utils/CheReporter.ts:156:81 - error TS2322: Type 'void' is not assignable to type 'WriteStream'.
156 screenshotStream.write(Buffer.from(screenshot, 'base64'), (): WriteStream => screenshotStream.end());
~~~~~~~~~~~~~~~~~~~~~~
utils/CheReporter.ts:161:71 - error TS2322: Type 'void' is not assignable to type 'WriteStream'.
161 pageSourceStream.write(Buffer.from(pageSource), (): WriteStream => pageSourceStream.end());
~~~~~~~~~~~~~~~~~~~~~~
Found 2 errors in the same file, starting at: utils/CheReporter.ts:156
There was a problem hiding this comment.
indeed
updated hasky pre-commit hook to prevent this kind of errors
nallikaea
force-pushed
the
22529
branch
2 times, most recently
from
9a52699 to
248a967
Compare
added 2 commits
September 20, 2023 18:13
Signed-off-by: mdolhalo <[email protected]>
Signed-off-by: mdolhalo <[email protected]>
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix #22529
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#22529
How to test this PR?
export USERSRORY=SmokeTest && npm run testPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.