Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fixed the correct path for starting 'cmake-gui' #533

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

gravemalte
Copy link
Contributor

@gravemalte gravemalte commented Aug 31, 2023

The follow-up PR for #532.

This PR fixed the wrong source flag which was set by spawning the cmake-gui command.

Closes #532

@jonahgraham
Copy link
Member

Thanks @daylien for this fix. I am going to rebase it and add it to 11.3.0 that is released very soon.

This PR fixed the wrong source flag which was set by spawning the cmake-gui command.

Closes eclipse-cdt#532
@jonahgraham jonahgraham changed the base branch from main to cdt_11_3 September 5, 2023 17:03
@jonahgraham jonahgraham added this to the 11.3.0 milestone Sep 5, 2023
@jonahgraham jonahgraham added the build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder label Sep 5, 2023
@jonahgraham jonahgraham changed the base branch from cdt_11_3 to main September 5, 2023 17:07
@jonahgraham jonahgraham merged commit 54a7f61 into eclipse-cdt:main Sep 5, 2023
3 checks passed
@gravemalte gravemalte deleted the cmake-gui-wrong-path branch September 5, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build components of CDT, anything to do with running the compiler, using Make, CMake, or any builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake: CMakePropertyPage_LaunchCMakeGui opens cmake-gui with wrong source path
2 participants