Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory search results page #516

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Improve memory search results page #516

merged 2 commits into from
Aug 18, 2023

Commits on Aug 18, 2023

  1. Improve memory search results page 

    The Memory Browser and Memory views will jump to the memory
address after a user selects a value from the Memory Search
Result list. If the views belong to the same tab group as
the Search view, then it might not be very intuitive for
the user to switch back to one of the Memory views and see
the effect of the selection.

The current commit adds on the the double click listener
(from MemorySearchResultsPage.java) the behavior to refocus
on the Memory Browser/ Memory view.

Resolves: eclipse-cdt#515
    @LizzMre @jonahgraham
    LizzMre authored and jonahgraham committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e0f3acb View commit details
    Browse the repository at this point in the history

  2. Code cleanup on Memory Search Result Page 

    - Use modern java instanceof
- Log unexpected exceptions
- reorder tests
- add missing null checks
- invert some if conditions for less nesting
    @LizzMre @jonahgraham
    LizzMre authored and jonahgraham committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    c37dca0 View commit details
    Browse the repository at this point in the history