Add support for the ANSI code for erasing characters #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
approved these changes
Aug 18, 2023
There was a problem hiding this comment.
@coehlrich I missed this PR as it came in during my vacation and in preparing for the M3 milestone next week I was reviewing the open PRs.
The change looks great to me and it is ready to merge now, I'm just going to rebase it to ensure that it passes all the code cleanliness checks.
jonahgraham
force-pushed
the
fix-powershell-prediction-erasing
branch
2 times, most recently
from
e12e0ec
to
572aeb4
Compare
jonahgraham
force-pushed
the
fix-powershell-prediction-erasing
branch
from
572aeb4
to
c39c14a
Compare
This escape sequence can be generated when using Powershell on Windows (and possibly other places too) to erase number of characters. Change-Id: I32405f51a3f91fd8653d44f2676a5c85b696ef99
jonahgraham
force-pushed
the
fix-powershell-prediction-erasing
branch
from
c39c14a
to
5f3a71a
Compare
jonahgraham
added
the
noteworthy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the ANSI code that erases characters which powershell uses to erase predictions.