Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing CDT-LSP does a partial CDT install #344

Open
jonahgraham opened this issue May 31, 2024 · 2 comments
Open

Installing CDT-LSP does a partial CDT install #344

jonahgraham opened this issue May 31, 2024 · 2 comments

Comments

@jonahgraham
Copy link
Member

If a user installs CDT-LSP (e.g. form SimRel) only a subset of CDT is installed, just those bundles directly referenced by CDT-LSP bundles.

I think it may be a good idea for CDT-LSP's feature to depend on CDT's main feature(s) so that the CDT install is complete (and updatable). For example, installing CDT-LSP will add the CDT-LSP update site (see #340) to available sites, but because the CDT features are not installed, the CDT update site won't be added.

It leaves users in a somewhat broken state, for example the new C/C++ wizard does not have any valid project types:

Page 1
image

Page 2
image

And there are no launch configurations:
image

@ghentschke
Copy link
Contributor

I am not sure what is the expectation here.
Does the CDT-LSP install provide the cdt-lsp bundles only or should it provide a whole cdt install as well?

I thought it should provide the two cdt-lsp bundles only.

@jonahgraham
Copy link
Member Author

Selecting CDT-LSP installs the org.eclipse.cdt.lsp.* bundles, and all the bundles that they depend on. So if a user doesn't have CDT installed, and they install CDT-LSP they end up in a weird situation.

I don't recommend we change this today, lets leave it until after the branch as the workaround is easy enough - to go back and install CDT's feature(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants