Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdt-lsp latest URL to available software sites #340

Closed
jonahgraham opened this issue May 31, 2024 · 4 comments · Fixed by #341
Closed

Add cdt-lsp latest URL to available software sites #340

jonahgraham opened this issue May 31, 2024 · 4 comments · Fixed by #341
Assignees
Milestone

Comments

@jonahgraham
Copy link
Member

To enable getting updates to users before the next SimRel we should add cdt-lsp to available software sites like we do for CDT:

image

This is how it is done for CDT:

https://github.com/eclipse-cdt/cdt/blob/8ac94b675f93fbcaccbedc5ca83903e7d438570b/releng/org.eclipse.cdt-feature/p2.inf#L1-L3

Remember to include the p2.inf (if new) in build.properties

https://github.com/eclipse-cdt/cdt/blob/f70a8b35c18a21a8cfb9132ad9de84caebac0d78/releng/org.eclipse.cdt-feature/build.properties#L16

@jonahgraham jonahgraham added this to the 2.0.0 milestone May 31, 2024
@jonahgraham
Copy link
Member Author

I'll do this next week before producing RC2 if no one gets to it or objects before then

@ghentschke
Copy link
Contributor

@jonahgraham I'll try to provide a PR for this today

@jonahgraham
Copy link
Member Author

Leaving open until this can be tested in EPP + manual install into Eclipse.

@jonahgraham
Copy link
Member Author

This change looks good:

image

But it introduces a new one that I should have realized before now. But I don't know if we should fix it. See #344

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants