Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guava version and dependency infrastructure #1292

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

donat
Copy link
Contributor

@donat donat commented Jan 9, 2024

No description provided.

@donat donat self-assigned this Jan 9, 2024
@donat donat added this to the 3.1.9 milestone Jan 9, 2024
@donat donat marked this pull request as ready for review January 9, 2024 12:43
@donat
Copy link
Contributor Author

donat commented Jan 9, 2024

CI build passed; merging.

@donat donat changed the title Update Guava version and update dependency infrastucture Update Guava version and dependency infrastructure Jan 9, 2024
@donat donat merged commit 5a51b88 into eclipse-buildship:master Jan 9, 2024
2 checks passed
@donat donat deleted the donat/update-guava branch January 9, 2024 12:46
@merks
Copy link

merks commented Jan 10, 2024

Thank you for working on this issue!! ❤️

There are currently only two contributions pulling in the older guava version:

image

It would be truly awesome if Buildship would contribute an update with the changes in the PR to SimRel for M1! The lsp4j work in also planned for today:

eclipse-lsp4j/lsp4j#782 (comment)

@merks
Copy link

merks commented Jan 10, 2024

We're down to just this dependency:

image

I tried testing locally with https://download.eclipse.org/buildship/updates/latest-snapshot to see if that has the changes, but alas it does not...

@donat
Copy link
Contributor Author

donat commented Jan 10, 2024

Thanks for directly reaching out to me. I've kicked off a snapshot release manually. I'll look into creating a patch release later this week.

merks added a commit to merks/simrel.build that referenced this pull request Jan 11, 2024
This uses a snapshop repo which is not a good thing, but since there is
nothing downstream from buildship in terms of dependencies, this should
not cause any problems. I really want to eliminate the older guava
version from M1 and this is the only way.

eclipse-buildship/buildship#1292
merks added a commit to eclipse-simrel/simrel.build that referenced this pull request Jan 11, 2024
This uses a snapshop repo which is not a good thing, but since there is
nothing downstream from buildship in terms of dependencies, this should
not cause any problems. I really want to eliminate the older guava
version from M1 and this is the only way.

eclipse-buildship/buildship#1292
@merks
Copy link

merks commented Jan 11, 2024

I hope you don't mind that I contributed your snapshot to SimRel. I really wanted the old version of Guava gone and some additional early testing of your release before you release it seems like a good thing...

@donat
Copy link
Contributor Author

donat commented Jan 11, 2024

No, not at all, thanks for doing that! I'll make sure to contribute a final Buildship release for the upcoming simrel.

@donat
Copy link
Contributor Author

donat commented Jan 16, 2024

@merks I've created a final release and going to add it to simrel: eclipse-simrel/simrel.build#189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants