-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Guava version and dependency infrastructure #1292
Conversation
CI build passed; merging. |
Thank you for working on this issue!! ❤️ There are currently only two contributions pulling in the older guava version: It would be truly awesome if Buildship would contribute an update with the changes in the PR to SimRel for M1! The lsp4j work in also planned for today: |
We're down to just this dependency: I tried testing locally with https://download.eclipse.org/buildship/updates/latest-snapshot to see if that has the changes, but alas it does not... |
Thanks for directly reaching out to me. I've kicked off a snapshot release manually. I'll look into creating a patch release later this week. |
This uses a snapshop repo which is not a good thing, but since there is nothing downstream from buildship in terms of dependencies, this should not cause any problems. I really want to eliminate the older guava version from M1 and this is the only way. eclipse-buildship/buildship#1292
This uses a snapshop repo which is not a good thing, but since there is nothing downstream from buildship in terms of dependencies, this should not cause any problems. I really want to eliminate the older guava version from M1 and this is the only way. eclipse-buildship/buildship#1292
I hope you don't mind that I contributed your snapshot to SimRel. I really wanted the old version of Guava gone and some additional early testing of your release before you release it seems like a good thing... |
No, not at all, thanks for doing that! I'll make sure to contribute a final Buildship release for the upcoming simrel. |
@merks I've created a final release and going to add it to simrel: eclipse-simrel/simrel.build#189 |
No description provided.