Move model creation outside of synchronized block #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinsch82
force-pushed
the
reinhold-attempt-to-fix-deadlock
branch
from
6ae27ac to
90bd252
Compare
donat
approved these changes
Jan 3, 2024
|
The changes passed CI; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1275
The deadlock seems to happen because
DefaultModelPersistence.this.lockis still locked whenPersistentModelConverter.toModelis called. Since the purpose of the lock is to synchronise access to the content of the property file this is not necessary.This change moves the call to
PersistentModelConverter.toModeloutside of the lock and should therefore avoid the deadlock situation.