This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Creates a local anonymous macro #579
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue with classloaders while running the test module from java. It works when run directly by golo. Here I switch the current thread classloader. Works fine, but there should be a better approach (thread local singleton for `Runtime.classLoader()`.
Define a thread local variable to hold the current thread classloader. When running from golo, the current thread classloader will be a GoloClassLoader instance, so it is used as is. The issue is that when running from Java, the current classloader is not a golo one, so it was wrapped by `Runtime.classLoader()`. We therefore got a different one for each call. Keeping it in a thread local singleton resolve this issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP