Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inherit default required status checks for ort-server #4

Conversation

mnonnenmacher
Copy link
Contributor

Do not inherit from the default required status checks in the ort-server repository. This effectively removes the eclipsefdn/eca check from the list of required checks. The reason is that this check is currently not triggered by the merge_group event and therefore the checks in the merge queue time out which makes it impossible to merge any pull requests. For details see 1.

The check can be made required again once 2 was implemented.

Do not inherit from the default required status checks in the ort-server
repository. This effectively removes the `eclipsefdn/eca` check from the
list of required checks. The reason is that this check is currently not
triggered by the `merge_group` event and therefore the checks in the
merge queue time out which makes it impossible to merge any pull
requests. For details see [1].

The check can be made required again once [2] was implemented.

[1]: eclipse-apoapsis#3 (comment)
[2]: https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/issues/161

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher requested a review from a team as a code owner March 20, 2024 13:57
Copy link
Contributor

This is your friendly self-service bot. The author (mnonnenmacher) of this PR is associated with this organization in the role of MEMBER.

Additionally, mnonnenmacher is a member of the following teams:

Copy link
Contributor

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for 32ef61d
Organization technology.apoapsis[id=eclipse-apoapsis]

  
!   branch_protection_rule[pattern="main", repository="ort-server"] {
!     required_status_checks            = "['eclipse-eca-validation:eclipsefdn/eca', 'build', 'commit-lint', 'detekt-issues', 'integration-test', 'reuse-tool', 'test', 'wrapper-validation']" -> "['build', 'commit-lint', 'detekt-issues', 'integration-test', 'reuse-tool', 'test', 'wrapper-validation']"
!   }
  
  Plan: 0 to add, 1 to change, 0 to delete.

Add a comment /help to get a list of available commands.

Copy link
Contributor

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

Copy link
Contributor

This is your friendly self-service bot.
This Pull Request is eligible for auto-merging as it passed the following checks:

  • valid configuration
  • does not require any secrets
  • does not require accessing the GitHub Web UI
  • approved by a project lead or a member of the EF security team

In order to automatically merge and apply the changes, add a comment /merge 🚀.

@mnonnenmacher
Copy link
Contributor Author

/merge

@eclipse-otterdog eclipse-otterdog bot merged commit 1366e15 into eclipse-apoapsis:main Mar 20, 2024
3 checks passed
Copy link
Contributor

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization technology.apoapsis[id=eclipse-apoapsis]

  
!   branch_protection_rule[pattern="main", repository="ort-server"] {
!     required_status_checks            = "['eclipse-eca-validation:eclipsefdn/eca', 'build', 'commit-lint', 'detekt-issues', 'integration-test', 'reuse-tool', 'test', 'wrapper-validation']" -> "['build', 'commit-lint', 'detekt-issues', 'integration-test', 'reuse-tool', 'test', 'wrapper-validation']"
!   }

  
  Applying changes:


  Done.
  
  Executed plan: 0 added, 1 changed, 0 deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant