-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure merge queue for the main branch #3
Comments
Thanks, looking good in my test PR eclipse-apoapsis/ort-server#1. |
@netomi There is one issue with the merge queue that is caused by the global
To solve this the on:
merge_group:
types: [checks_requested] What would be the correct place to request such a change? |
So the eclipsefdn/eca status check is not handled via a workflow but through a GitHub App that reacts on webhook events. As a short term solution, we can remove the eclipsefdn/eca check from the list of required checks in the branch protection rule. to - required_status_checks+: [
+ required_status_checks: [ so the eca check is not inherited from the default config. |
Thanks for the explanation and creating the ticket. I will apply the workaround for now. |
Do not inherit from the default required status checks in the ort-server repository. This effectively removes the `eclipsefdn/eca` check from the list of required checks. The reason is that this check is currently not triggered by the `merge_group` event and therefore the checks in the merge queue time out which makes it impossible to merge any pull requests. For details see [1]. The check can be made required again once [2] was implemented. [1]: eclipse-apoapsis#3 (comment) [2]: https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/issues/161 Signed-off-by: Martin Nonnenmacher <[email protected]>
Do not inherit from the default required status checks in the ort-server repository. This effectively removes the `eclipsefdn/eca` check from the list of required checks. The reason is that this check is currently not triggered by the `merge_group` event and therefore the checks in the merge queue time out which makes it impossible to merge any pull requests. For details see [1]. The check can be made required again once [2] was implemented. [1]: #3 (comment) [2]: https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/issues/161 Signed-off-by: Martin Nonnenmacher <[email protected]>
Please enable the merge queue as part of the branch protection rules for the main branch as this can currently not be done via Otterdog (see eclipse-csi/otterdog#86).
The required settings are:
Merge method: "Rebase and merge"
Maximum pull requests to build: 5
Minimum pull requests to merge: 1 or after 5 minutes
Maximum pull requests to merge: 5
Only merge non-failing pull requests: true
Consider check failed after: 60 minutes
The text was updated successfully, but these errors were encountered: