Fixing reported heap corruption when releasing native memory #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Visual Studio debugger was reporting that there was heap corruption when attempting to call
Marshal.FreeHGlobal
. It appears that this uses a different heap than what the native side uses for allocation withmalloc
. To ensure that the same heap is used, a new export from zopfli.dll was added (ZopfliFree
) to perform the companionfree
call - and the managed side now calls into this.Since I couldn't find the original (assumed modified) sources for the zopfli.dll, I had to re-implement the
ZopfliPNGExternalOptimize
exported function as well to ensure the PNG compression still worked. For future reference, the implementations are:and,
I used the Zopfli sources from the 1.0.2 release and I rebuilt the DLL binaries in Release under VS 15.7.1, and statically linked the runtime into it.