Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for column 27: E_we-E_ce/V #98

Merged
merged 3 commits into from
Jan 20, 2024
Merged

add support for column 27: E_we-E_ce/V #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fec3a22
add support for column 27: E_we-E_ce/V (fix #74)
Nov 17, 2022
0b5b5b8
Merge branch 'master' into col-27-ewe-ece
chatcannon Jan 20, 2024
9a61eb3
add test for column 27 (E_we - E_ce)
Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions galvani/BioLogic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ def MPTfileCSV(file_or_path):
23: ("dQ/mA.h", "<f8"), # Same as 7?
24: ("cycle number", "<f8"),
26: ("Rapp/Ohm", "<f4"),
27: ("Ewe-Ece/V", "<f4"),
32: ("freq/Hz", "<f4"),
33: ("|Ewe|/V", "<f4"),
34: ("|I|/A", "<f4"),
Expand Down
1 change: 1 addition & 0 deletions tests/test_BioLogic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ def test_parse_BioLogic_date(data, expected):
("C019P-0ppb-A_C01.mpr", "2019-03-14", "2019-03-14"),
("Rapp_Error.mpr", "2010-12-02", "2010-12-02"),
("Ewe_Error.mpr", "2021-11-18", "2021-11-19"),
("col_27_issue_74.mpr", "2022-07-28", "2022-07-28"),
],
)
def test_MPR_dates(testdata_dir, filename, startdate, enddate):
Expand Down
3 changes: 3 additions & 0 deletions tests/testdata/col_27_issue_74.mpr
View file
Open in desktop
Git LFS file not shown