Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for column 27: E_we-E_ce/V (fix #74) #78

Closed
wants to merge 2 commits into from

Conversation

ilka-schulz
Copy link

adds support for column with id=27

The column holds a value name E_we - E_ce described as WE versus CE potential in the manual.

@ilka-schulz
Copy link
Author

Example files: #74 (comment)

@ilka-schulz
Copy link
Author

Oh, wait a moment with merging. I will add a test file.

@ilka-schulz
Copy link
Author

@chatcannon feel free to merge

@chatcannon
Copy link
Collaborator

The test file should be added as a git-lfs file, not directly to the git repo - see my comment on #79

@chatcannon
Copy link
Collaborator

You probably also want to add SPDX metadata for the test data file using a *.license file.

@chatcannon
Copy link
Collaborator

Clearly @ilka-schulz has no intention of making the changes I asked for. I will try doing it myself.

@chatcannon
Copy link
Collaborator

superseded by #98

@chatcannon chatcannon closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants