Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error thrown when using NoVerifyHTTPAdapter with requests 2.32.3 #1320

Merged

Conversation

jamaalscarlett
Copy link
Contributor

@jamaalscarlett jamaalscarlett commented Jul 11, 2024

Overrides get_connection_with_tls_context on the adapter to set verify=False.

Fixes:
#1314
psf/requests#6719

@jamaalscarlett jamaalscarlett force-pushed the fix_no_verify_adapter branch 2 times, most recently from f92b0c6 to d06f7e0 Compare July 11, 2024 04:35
Overrides get_connection_with_tls_context on the adapter to set verify=False.
@coveralls
Copy link

Coverage Status

coverage: 58.554% (-38.2%) from 96.712%
when pulling 25d3d93 on jamaalscarlett:fix_no_verify_adapter
into 5fa602e on ecederstrand:master.

@ecederstrand ecederstrand merged commit 7350d3d into ecederstrand:master Jul 11, 2024
8 of 11 checks passed
@ecederstrand
Copy link
Owner

Thanks!

@jamaalscarlett jamaalscarlett deleted the fix_no_verify_adapter branch July 11, 2024 13:22
@jamaalscarlett
Copy link
Contributor Author

My pleasure.

@jamaalscarlett
Copy link
Contributor Author

@ecederstrand Any change we could get a new version, this issue is currently blocking our upgrade to the latest requests.

@ecederstrand
Copy link
Owner

I'll get around to it soon, but might not be this week.

Until then, you can just create your own adapter class from NoVerifyHTTPAdapter with the new method, and use that as your adapter class instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants