s_volume becomes mastervolume for s_musicvolume

[ghost]

No description provided.

[ghost]

Just a NOTE: it seems different people expect different behaviour: ioquake/ioq3#502
Personally I can't say what the 'correct' behaviour is. Maybe, three cvars? s_effectsVolume, s_musicVolume, s_volume? s_volume that reduces volume for both at once than?

[ec-]

Well, it seems to broke config compatibility a bit but current behavior (-independend sfx and music control) is more convenient because you can emulate any vq3 combinations with it - while opposite (like sfx_vol=0 + musiv_vol=1 i.e. leave only music) is not possible

[ghost]

Just a NOTE: it seems different people expect different behaviour: ioquake/ioq3#502 Personally I can't say what the 'correct' behaviour is. Maybe, three cvars? s_effectsVolume, s_musicVolume, s_volume? s_volume that reduces volume for both at once than?

My original idea was to add s_mastervolume to control everything, Is this okay?

[ghost]

I feel that having s_volume as the master volume is what it was originally supposed to be, but anyways, I added 's_mastervolume'.

[ghost]

I think if you call current s_volume something different (something like s_effectsVolume) and s_volume will act as your 'mastervolume' than even existing cfgs will not break (something ec- tries to avoid if I'm correct).
This would be more user friendly, maybe.