Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupler pathways inference from differential expression files #339

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

pcm32
Copy link
Member

@pcm32 pcm32 commented Nov 28, 2024

Description

This enables the decoupler pathways inference tool to run from differential expression tsv files.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have made any required changes to upstream dependencies for a tool wrapper, and they are available in distribution channels (e.g. Pip, Conda).
  • If I have updated the underlying software for a tool wrapper (e.g. scanpy-scripts by changing the value of @TOOL_VERSION@), then I have reset all 'build' values to 0 (e.g. @TOOL_VERSION@+galaxy0)
  • If I have updated a tool wrapper without a software change, then I have bumped the associated 'build' values (e.g. @TOOL_VERSION@+galaxy0 @TOOL_VERSION@+galaxy1). It is acceptable to do this as well when the cli version changed but not the underlying tool (to avoid issues in the coming point).
  • If I changed the version, the @TOOL_VERSION@ part of the version does not contain any + symbols within, otherwise this will break tool ordering on the interface and the default tool being picked. Tool version should always conform to PEP440 to avoid this issue. The only + should be the one preceding galaxy<build> (unless that all the versions from that tool previously followed a different pattern).

@pcm32 pcm32 requested a review from anilthanki November 28, 2024 23:30
# read in the AnnData input file
adata = ad.read_h5ad(args.input_anndata)
# detect based on input file extension if the input file is AnnData or matrix
if args.input.endswith(".h5ad"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about input file with .h5 extension

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not needed, since this is internally controlled with the galaxy wrapper, which will transform the filename forcefully into input.h5ad . Also the extension .h5 is generally used for any HDF5 file, not just AnnData, the community tends to favour .h5ad for anndata (although it is just a convention).

@pcm32
Copy link
Member Author

pcm32 commented Nov 29, 2024

Last commit broke the python linting, I don't think is really worth it, so I will reverse it.

@pcm32 pcm32 force-pushed the feature/decoupler_path_inf_from_matrix branch from 96e6db7 to 60d94b0 Compare November 29, 2024 10:40
Copy link
Collaborator

@anilthanki anilthanki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcm32 pcm32 merged commit b581a5b into main Nov 29, 2024
24 checks passed
@pcm32 pcm32 deleted the feature/decoupler_path_inf_from_matrix branch November 29, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants