Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Single Cell and Spatial Omics shed categories #335

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pavanvidem
Copy link
Collaborator

Description

Adds recently introduced Single Cell and Spatial Omics shed categories in .shed.yml of all the relevant tools. @pcm32 having this ready asap will help @nomadscientist for her biohackathon project next week. Thanks!

@pcm32
Copy link
Member

pcm32 commented Oct 30, 2024

..hehehehe... you're opening a pandora box here with the older tools @pavanvidem :-).

I'm all good with this, but, do you know if there are any unintended consequences of pushing again to the tooldshed tools with the same versions and galaxy build numbers? I wouldn't want to mangle the content on the toolshed like that (but maybe the toolshed handles this gracefully, I don't know).

@pavanvidem
Copy link
Collaborator Author

afaik, toolshed wouldn't notice the changes in .shed.yml until there is a tool update. Anyways, .shed.yml has only tool metdatata, nothing specific related to the versions.

@pcm32
Copy link
Member

pcm32 commented Oct 31, 2024

the problem we have though is that the CI is what pushing to the toolshed, and the CI won't push things if tests are not passed :-(, so not sure how to do this (as fixing all the newer requirements from the CI is beyond anyone's time availability). In other words, even if I would merge, the changes wouldn't be pushed...

@pcm32
Copy link
Member

pcm32 commented Oct 31, 2024

Maybe if we limit this for the tools that are really needed?

@pavanvidem
Copy link
Collaborator Author

They don't need to be pushed into the toolshed. It seems Galaxy Tool Metadata Extractor parses only the .shed.yml files not the toolshed. So it should be enough to have the Single Cell category the .shed.yml files. Btw, we also add these categories to all the single cell Galaxy tools from iuc and galaxytools repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants