Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupler Pathway Inference #308

Merged
merged 60 commits into from
Mar 15, 2024
Merged

Conversation

anilthanki
Copy link
Collaborator

@anilthanki anilthanki commented Nov 3, 2023

Description

Adds the ability to calculate pathway inference through Decoupler.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have made any required changes to upstream dependencies for a tool wrapper, and they are available in distribution channels (e.g. Pip, Conda).
  • If I have updated the underlying software for a tool wrapper (e.g. scanpy-scripts by changing the value of @TOOL_VERSION@), then I have reset all 'build' values to 0 (e.g. @TOOL_VERSION@+galaxy0)
  • If I have updated a tool wrapper without a software change, then I have bumped the associated 'build' values (e.g. @TOOL_VERSION@+galaxy0 @TOOL_VERSION@+galaxy1). It is acceptable to do this as well when the cli version changed but not the underlying tool (to avoid issues in the coming point).
  • If I changed the version, the @TOOL_VERSION@ part of the version does not contain any + symbols within, otherwise this will break tool ordering on the interface and the default tool being picked. Tool version should always conform to PEP440 to avoid this issue. The only + should be the one preceding galaxy<build> (unless that all the versions from that tool previously followed a different pattern).

@anilthanki anilthanki marked this pull request as draft November 3, 2023 10:01
@anilthanki anilthanki requested a review from pcm32 November 3, 2023 10:01
@anilthanki anilthanki force-pushed the feature/decoupler_pathway_inference branch from 9efe1e4 to 1db7706 Compare November 10, 2023 09:40
@anilthanki anilthanki force-pushed the feature/decoupler_pathway_inference branch from 7944106 to fd8f001 Compare November 24, 2023 13:04
@anilthanki anilthanki requested a review from pcm32 January 11, 2024 10:02
Copy link
Member

@pcm32 pcm32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good and I think is nearly there for merging. I wonder if adding ULM is too much work?

Copy link
Member

@pcm32 pcm32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, plots can be done from the activities AnnData in a separate call in Galaxy. I added some minor rewordings for help parts.

@anilthanki anilthanki merged commit 1034a45 into develop Mar 15, 2024
6 checks passed
@anilthanki anilthanki deleted the feature/decoupler_pathway_inference branch March 15, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants