-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoupler Pathway Inference #308
Conversation
9efe1e4
to
1db7706
Compare
7944106
to
fd8f001
Compare
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good and I think is nearly there for merging. I wonder if adding ULM is too much work?
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Pablo Moreno <[email protected]>
Co-authored-by: Pablo Moreno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, plots can be done from the activities AnnData in a separate call in Galaxy. I added some minor rewordings for help parts.
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
tools/tertiary-analysis/decoupler/decoupler_pathway_inference.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Pablo Moreno <[email protected]>
Co-authored-by: Pablo Moreno <[email protected]>
Co-authored-by: Pablo Moreno <[email protected]>
Co-authored-by: Pablo Moreno <[email protected]>
Co-authored-by: Pablo Moreno <[email protected]>
Co-authored-by: Pablo Moreno <[email protected]>
Description
Adds the ability to calculate pathway inference through Decoupler.
Fixes # (issue)
Type of change
Checklist
@TOOL_VERSION@
), then I have reset all 'build' values to 0 (e.g.@TOOL_VERSION@+galaxy0
)@TOOL_VERSION@+galaxy0
@TOOL_VERSION@+galaxy1
). It is acceptable to do this as well when the cli version changed but not the underlying tool (to avoid issues in the coming point).@TOOL_VERSION@
part of the version does not contain any+
symbols within, otherwise this will break tool ordering on the interface and the default tool being picked. Tool version should always conform to PEP440 to avoid this issue. The only+
should be the one precedinggalaxy<build>
(unless that all the versions from that tool previously followed a different pattern).