Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Add species when redirect to metadata search #434

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Jul 8, 2024

In our basic /search endpoint when we redirected the search we did not added species as a request parameter if the search category was metadata. In any other search category the species was added as a request parameter.

@ke4 ke4 added the bug Something isn't working label Jul 8, 2024
@ke4 ke4 requested review from upendrakumbham and lingyun1010 July 8, 2024 13:10
@ke4 ke4 self-assigned this Jul 8, 2024
Copy link
Contributor

@upendrakumbham upendrakumbham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lingyun1010
Copy link
Contributor

lingyun1010 commented Jul 8, 2024

Looks good but please get the Jenkins build pass before merging. Thanks.

@ke4
Copy link
Contributor Author

ke4 commented Jul 8, 2024

@lingyun1010 Yep. I think our test DB or some of our experiments are not correct as it is failing in a test where it should not if the data in our DB and Solr is correct.
Anyway, I am going to trigger a new build. 🙏

@ke4 ke4 merged commit 3cebf40 into develop Jul 8, 2024
3 checks passed
@ke4 ke4 deleted the bugfix/species_param_not_transfered_from_search branch July 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Species filter is getting ignored in the metadata search
3 participants