Fix container building by moving to ubuntu-latest #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcm32
changed the title
|
Moving to ubuntu-latest at least fixed the container building for the jupyter image I was after. However, the CI won't try building the github actions container (which hasn't been built in a while) because that only happens on merge to master. Should we give this a try @alfonsomunozpomer @pmb59 ? That github actions runner only affects the galaxy tools I think. But I suspect that other containers being merged have not been pushed recently. |
anilthanki
reviewed
Oct 13, 2023
| - "*/post_install_dockerfile" | ||
| - "miniconda_template/*" | ||
| - ".github/workflows/miniconda_template.yaml" | ||
|
|
||
| jobs: | ||
| getchanges: | ||
| name: Get changed repos | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
using latest here will always use stable or LTS version right?
There was a problem hiding this comment.
Yes, it is usually the latest "stable" image. Since this is the OS, this should be relatively safe, currently points to 22.04 I think.
anilthanki
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container building seems broken. I will start by trying changing the OS.