Bugfix/species filter is getting ignored in the metadata search #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… onchange event and maintaining species state
… trigger onchange event and maintaining species state" This reverts commit e12a243.
… the state to pass it to the cell type wheel endpoint
…-type-wheel endpoint with the selected species value
…map component to trigger wheel endpoint when we change species drop down
…peWheelFetchLoader and add host
ke4
requested changes
Aug 5, 2024
packages/scxa-cell-type-wheel-experiment-heatmap/src/CellTypeWheelExperimentHeatmap.js
Outdated
Show resolved
Hide resolved
3 tasks
Co-authored-by: Károly Erdős <[email protected]>
|
FIxed both, thanks for the comments. |
ke4
requested changes
Aug 6, 2024
| /> | ||
| <div className={`row-expanded small-12 columns`}> | ||
| <div className={`small-12 medium-6 columns`} aria-label={`Cell type wheel`}> | ||
| {props.searchTerm.trim() ? | ||
| <CellTypeWheelFetchLoader | ||
| host={props.host} | ||
| resource={URI(props.cellTypeWheelResource) | ||
| resource={URI(props.cellTypeWheelResource) |
There was a problem hiding this comment.
I know it is a tiny formatting thing, but could you restore the aligning of this line, please?
There was a problem hiding this comment.
sorry, not sure, how it was disturbed, it makes sense. Thanks for that.
There was a problem hiding this comment.
I fixed formatting, please feel free to review when log in
ke4
approved these changes
Aug 7, 2024
upendrakumbham
deleted the
bugfix/species_filter_is_getting_ignored_in_the_metadata_search
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Our cell type wheel is not refreshing with the latest species drop-down value change. Simply, the wheel is ignoring species dropdown.
This PR - Fixes that issue
To Fix this:
I have modified two components:
Changes:
onchangefunction to notify the gene search form when species changed from the species drop-downLocal testing:
'npm pack'in the scxa-gene search Form component andtgzfile will be generated in that component after npm packnpm install <path>in the scxa-cell-type-wheel-experiment-heatmap componentnpx webpack-dev-server --mode=development