Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fastCheck, move startMs and move setAutoCommitFalse() #148

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Refactor fastCheck, move startMs and move setAutoCommitFalse() #148

merged 2 commits into from
Nov 3, 2023

Conversation

rbygrave
Copy link
Member

@rbygrave rbygrave commented Nov 3, 2023

  • Move startMs to be before the resource loading (include that in the time)
  • Move the setAutoCommitFalse() to occur after fastCheck query (nb: the fast check query will rollback() if executed
  • Move fast check logic into FirstCheck class
  • Rename method derivePlatformName() -> derivePlatform())
  • Change MigrationTable constructor to task FirstCheck

@rbygrave
Refactor fastCheck, move startMs and move setAutoCommitFalse()
82ca9cf 
- Move startMs to be before the resource loading (include that in the time)
- Move the setAutoCommitFalse() to occur after fastCheck query
  (nb: the fast check query will rollback() if executed
- Move fast check logic into FirstCheck class
- Rename method derivePlatformName() -> derivePlatform())
- Change MigrationTable constructor to task FirstCheck
@rbygrave rbygrave self-assigned this Nov 3, 2023
@rbygrave rbygrave added this to the 13.11.1 milestone Nov 3, 2023
@rbygrave rbygrave merged commit 6055840 into master Nov 3, 2023
2 checks passed
@rbygrave rbygrave deleted the feature/refactor-fastCheck branch November 3, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
13.11.1
Development

Successfully merging this pull request may close these issues.
1 participant
@rbygrave