Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve trim skipping minConnections for max idle #92

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Improve trim skipping minConnections for max idle #92

merged 1 commit into from
Mar 11, 2024

Conversation

rbygrave
Copy link
Member

Improve trimInactiveConnections() to:

  • only trim on idle when freeList.size() > minSize
  • only trim on maxAge when createdSince > 0
  • skip the first minSize connections when trimming on idle
  • only ensureMinConnections() when connections were trimmed

Also tidy code when using heartbeatSql via try-with-resources

@rbygrave rbygrave self-assigned this Mar 11, 2024
@rbygrave rbygrave added this to the 8.13 milestone Mar 11, 2024
@rbygrave rbygrave merged commit d2a2a2e into master Mar 11, 2024
2 checks passed
@rbygrave rbygrave deleted the feature/trim-min-idle branch March 11, 2024 09:40
rbygrave added a commit that referenced this pull request Mar 11, 2024
@rbygrave
Backport trimInactiveConnections() improvements
dd76813 
from #92
@rbygrave rbygrave mentioned this pull request Mar 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbygrave rbygrave

Labels
None yet
Projects
None yet
Milestone
8.13
Development

Successfully merging this pull request may close these issues.
1 participant
@rbygrave