Add shutdown listener, which shuts down the pool on JVM exit #88
Conversation
|
@rbygrave I plan to contiune the work on the serviceloader in about 2-3 weeks can you take a look at this and maybe at ebean-orm/ebean-migration#153 in the meantime? |
|
I'm not sure if this is a good idea at the moment. |
|
Hi @rPraml when do you think it is a good idea to use this shutdown hook? In general we do not want this when using Ebean Database because shutdown ordering is important and io.ebean.Database controls the order of shutdown and currently does the correct thing in terms of shutdown order. The only time I'd expect people to use this is when they are using ebean-datasource without using io.ebean.Database. Is that your expectation? If so, why is this defaulting to be on? The counter argument is that as long as new requests for connections are not being made then shutdown() can be requested and it will wait for busy connections to complete. I presume this is the thinking behind making this true by default? |
- Default this to off for now - Adjust to support DataSourceBuilder (preferred going forward) - Change to log at INFO for when the hook is run - Adjust the test to include an already shutdown pool
|
Going with leaving this off by default. I believe we could make this on by default ... and then have ebean turn it off for it's use case (where ebean wants to control the shutdown order and specifically shutdown the pool after any background tasks have completed). |
Refering to the problem here ebean-orm/ebean-migration#153 I've tried to implement a shutdown listener.
The problem is, that H2 needs ~4 seconds to shut down open connections when the JVM exits