Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is arguable, and it's completely OK to banish it from existence if you don't feel it fits the project well
It does these things:
KDE_SUPPORT
for Plasma 6 (which is dependent on qt6, so I don't see the point in supporting EOL qt5)Exiv2::enableBMFF(true);
is deprecated and seems not needed anymoregcc warnings stuff may be backported to a current version, that utilizes the qt5, but the kf6 fixes aren't, afaik
Also a note about
mainwindow.cpp
changes forkf6
: theKWindowEffects::enableBlurBehind
now takesQWindow
instead ofwinId
, and while theapplyWindowedBackground
was being calledapplyWindowedBackground
withkf5
wasn't a bad thing, now it crashes, because the window not exists on a first call. That's why the check here is needed, though it's a bit nasty