Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor generation of required environment variables in module files + deprecate make_module_req_guess method in EasyBlock class #4653

Open
wants to merge 38 commits into
base: 5.0.x
Choose a base branch
from
Open

refactor generation of required environment variables in module files + deprecate make_module_req_guess method in EasyBlock class #4653

wants to merge 38 commits into from
+408 −106

Commits on Sep 23, 2024

  1. refactor generation of required environment variables in module files

    @lexming
    lexming committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    734cd99 View commit details
    Browse the repository at this point in the history

  2. update test_make_module_req to add a file into MANPATH of test instal… 

    …lation
    @lexming
    lexming committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    df505cf View commit details
    Browse the repository at this point in the history

  3. disable non-empty check on search path drectories for fake module files

    @lexming
    lexming committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5680038 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. change position of easyblock methods make_module_req_guess and _expan… 

    …d_module_search_path
    @lexming
    lexming committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5b17f2e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. add new class ModuleEnvironmentVariable to hold definitions of enviro… 

    …nment variables for module files
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    9205c3b View commit details
    Browse the repository at this point in the history

  2. add new class ModuleLoadEnvironment to hold environment definition fo… 

    …r modules on load
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    29affc9 View commit details
    Browse the repository at this point in the history

  3. add LibSymlink enum to easyblock to define possible states of symlink… 

    …ed library directories
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8d3a051 View commit details
    Browse the repository at this point in the history

  4. set library symlink state at the end of post_install_step

    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    ee37ae7 View commit details
    Browse the repository at this point in the history

  5. use environment definition from ModuleLoadEnvironment in make_module_… 

    …req_guess
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    b6e1821 View commit details
    Browse the repository at this point in the history

  6. deprecate make_module_req_guess in favor of directly using ModuleLoad… 

    …Environment
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    544a316 View commit details
    Browse the repository at this point in the history

  7. consider both possible symplink states between lib and lib64 in expan… 

    …ding paths for environment of modules
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    dc09eee View commit details
    Browse the repository at this point in the history

  8. fix code style around ModuleEnvironmentVariable

    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    562c98d View commit details
    Browse the repository at this point in the history

  9. add check_install_lib_symlink method to EasyBlock to be able to trigg… 

    …er explicit checks in the module step
    @lexming
    lexming committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    17cc73f View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. remove unused empty attribute from ModuleEnvironmentVariable

    @lexming
    lexming committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    16e4743 View commit details
    Browse the repository at this point in the history

  2. attributes in ModuleLoadEnvironment can only be instances of ModuleEn… 

    …vironmentVariable
    @lexming
    lexming committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    f68f383 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Merge branch '5.0.x' into cpath-mod

    @lexming
    lexming committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0b81a21 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. add test to verify that environment variables don't leak into module … 

    …file of subsequent installations
    @boegel
    boegel committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    36d4f92 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge pull request #5 from boegel/cpath-mod 

    add test to verify that environment variables don't leak into module file of subsequent installations
    @lexming
    lexming authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    fa25ae2 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch '5.0.x' into cpath-mod

    @lexming
    lexming committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    50b9195 View commit details
    Browse the repository at this point in the history

  2. convert ModuleLoadEnvironment to regular class instead of singleton

    @lexming
    lexming committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d560ce2 View commit details
    Browse the repository at this point in the history

  3. enable raising of errors when running toy build in test_toy_multiple_… 

    …ecs_module
    @boegel
    boegel committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9a230cf View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. fix test_toy_multiple_ecs_module when using Tcl as module syntax

    @boegel
    boegel committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f43ae67 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Merge branch '5.0.x' into cpath-mod

    @lexming
    lexming committed Nov 10, 2024
    Configuration menu
    Copy the full SHA
    0b17167 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. fix deprecation warning about make_module_req_guess

    @lexming
    lexming committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fad0926 View commit details
    Browse the repository at this point in the history

  2. make ModuleEnvironmentVariable iterable

    @lexming
    lexming committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5f04fc3 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. ModuleEnvironmentVariable repr corresponds to its list of paths

    @lexming
    lexming committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a45783e View commit details
    Browse the repository at this point in the history

  2. add update method to ModuleEnvironmentVariable to replace its list of… 

    … paths
    @lexming
    lexming committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b330d84 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. add logging facility to ModuleEnvironmentVariable

    @lexming
    lexming committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    c67afd4 View commit details
    Browse the repository at this point in the history

  2. add remove method to ModuleEnvironmentVariable

    @lexming
    lexming committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6048010 View commit details
    Browse the repository at this point in the history

  3. rename ModuleEnvironmentVariable.paths to ModuleEnvironmentVariable.c… 

    …ontents
    @lexming
    lexming committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    de3fa38 View commit details
    Browse the repository at this point in the history

  4. ensure ModuleEnvironmentVariable is a list of unique strings

    @lexming
    lexming committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0274faf View commit details
    Browse the repository at this point in the history

  5. make EasyBlock._expand_module_search_path a public method

    @lexming
    lexming committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    5b4372e View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. fix codestyle issues

    @lexming
    lexming committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f20adb8 View commit details
    Browse the repository at this point in the history

  2. replace make_module_req_guess with module_load_environment in Toy eas… 

    …yblock
    @lexming
    lexming committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    03c6c46 View commit details
    Browse the repository at this point in the history

  3. ExtensionEasyBlock pulls module load environment from its master

    @lexming
    lexming committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d43acae View commit details
    Browse the repository at this point in the history

  4. automatically enforce top level files for PATH and LD_LIBRARY_PATH in… 

    … module load environment
    @lexming
    lexming committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c692e66 View commit details
    Browse the repository at this point in the history

  5. replace make_module_req_guess with module_load_environment in test_ma… 

    …ke_module_req
    @lexming
    lexming committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    561d89e View commit details
    Browse the repository at this point in the history

  6. allow to customize delimiter in ModuleEnvironmentVariable

    @lexming
    lexming committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a514a42 View commit details
    Browse the repository at this point in the history