Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/13.3.0] SlurmViewer v1.0.2 #22045

Merged
merged 12 commits into from
Dec 20, 2024

Conversation

prerakmody
Copy link
Contributor

PR created using github UI

Copy link

github-actions bot commented Dec 17, 2024

Updated software SlurmViewer-1.0.2-GCCcore-13.3.0.eb

Diff against SlurmViewer-1.0.1-GCCcore-13.2.0.eb

easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.1-GCCcore-13.2.0.eb

diff --git a/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.1-GCCcore-13.2.0.eb b/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.2-GCCcore-13.3.0.eb
index 371a8d85ee..9474793b5b 100644
--- a/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.1-GCCcore-13.2.0.eb
+++ b/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.2-GCCcore-13.3.0.eb
@@ -1,23 +1,29 @@
+# #
+# Authors:    
+#  - Patrick de Koning <[email protected]>
+#  - Prerak Mody <[email protected]>
+# #
 easyblock = 'PythonBundle'
 
 name = 'SlurmViewer'
-version = '1.0.1'
+version = '1.0.2'
 
 homepage = 'https://gitlab.com/lkeb/slurm_viewer'
-description = """View the status of a Slurm cluster, including nodes and queue."""
+description = """One-stop command to view the status of a Slurm cluster,
+including nodes, jobs and resource utilization."""
 
-toolchain = {'name': 'GCCcore', 'version': '13.2.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
 builddependencies = [
-    ('binutils', '2.40'),
-    ('hatchling', '1.18.0'),
-    ('poetry', '1.6.1'),
+    ('binutils', '2.42'),
+    ('hatchling', '1.24.2'),
+    ('poetry', '1.8.3'),
 ]
 
 dependencies = [
-    ('Python', '3.11.5'),
-    ('Python-bundle-PyPI', '2023.10'),
-    ('pydantic', '2.7.4'),
+    ('Python', '3.12.3'),
+    ('Python-bundle-PyPI', '2024.06'),
+    ('pydantic', '2.9.1'),
 ]
 
 use_pip = True
@@ -38,19 +44,19 @@ exts_list = [
     }),
     ('slurm-viewer', version, {
         'source_tmpl': 'slurm_viewer-%(version)s-py3-none-any.whl',
-        'checksums': ['2e42662881458701a09770a52062cb065527e30a39aac35165056f4ccf288f52'],
+        'checksums': ['00baa6a9b26b36592e361486d58df3d68a8df970dfc66ebc2ba7cdd67994bfe0'],
     }),
 ]
 
 sanity_check_paths = {
-    'files': ['bin/slurm-viewer', 'bin/slurm-viewer-init'],
+    'files': ['bin/slurm-viewer'],
     'dirs': ['lib']
 }
 
 sanity_pip_check = True
 
-modloadmsg = """Slurm Viewer requires a configuration file.
-You can make a default settings file in your home directory by running slurm-viewer-init,
-or you can point to a settings file by setting the environment variable $SLURM_VIEW_CONFIG."""
+modloadmsg = """Slurm Viewer uses a configuration file.
+This is made by default (from v1.0.2) in the ~/.config/slurm-viewer/ directory.
+You can also point to a settings file by setting the environment variable $SLURM_VIEW_CONFIG."""
 
 moduleclass = 'tools'

@prerakmody
Copy link
Contributor Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@prerakmody: I noticed your comment, but I only dance when @akesandgren or @bartoldeman or @bedroge or @boegel or @branfosj or @casparvl or @jfgrimm or @lexming or @Micket or @migueldiascosta or @ocaisa or @SebastianAchilles or @smoors or @verdurin or @robert-mijakovic or @deniskristak or @ItIsI-Orient or @PetrKralCZ or @sassy-crick or @laraPPr or @pavelToman or @Louwrensth or @Thyre tells me (for now), I'm sorry...

- notification for comment with ID 2548742892 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@robert-mijakovic
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@robert-mijakovic: Request for testing this PR well received on login1

PR test command 'EB_PR=22045 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22045 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14880

Test results coming soon (I hope)...

- notification for comment with ID 2548754159 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge bedroge changed the title Added SlurmViewer-1.0.2 {tools}[GCCcore/13.3.0] SlurmViewer v1.0.2 Dec 17, 2024
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested changes bump all dependencies to a version that uses the same toolchain/compiler. I haven't checked if these versions are compatible with your Slurm-Viewer requirements, though.

@bedroge
Copy link
Contributor

bedroge commented Dec 19, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 24.04.1 LTS (Noble Numbat), x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.12.3
See https://gist.github.com/bedroge/7411635b3402f550333e69fd7d11bd89 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Dec 19, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=22045 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22045 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14887

Test results coming soon (I hope)...

- notification for comment with ID 2553242216 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/cf876a9d499db0259f79d35f7518b524 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Dec 19, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22045 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22045 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5465

Test results coming soon (I hope)...

- notification for comment with ID 2553286403 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/685c2c9a9b829645de6092d12261afed for a full test report.

…lurmViewer-1.0.2-GCCcore-13.3.0.eb

Co-authored-by: Bob Dröge <[email protected]>
@bedroge
Copy link
Contributor

bedroge commented Dec 20, 2024

@boegelbot please test @ generoso

@bedroge
Copy link
Contributor

bedroge commented Dec 20, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 24.04.1 LTS (Noble Numbat), x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.12.3
See https://gist.github.com/bedroge/7d0f64a6c1e2934e460c7d0a48b6d6f3 for a full test report.

@bedroge bedroge added this to the release after 4.9.4 milestone Dec 20, 2024
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=22045 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22045 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14896

Test results coming soon (I hope)...

- notification for comment with ID 2556510207 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4664a8dc03e91b7a69f1752249c307b0 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Dec 20, 2024

Going in, thanks @prerakmody!

@bedroge bedroge merged commit 718334b into easybuilders:develop Dec 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants