Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/13.3.0] SlurmViewer v1.0.2 #22045

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

prerakmody
Copy link

PR created using github UI

Copy link

github-actions bot commented Dec 17, 2024

Updated software SlurmViewer-1.0.2-GCCcore-13.3.0.eb

Diff against SlurmViewer-1.0.1-GCCcore-13.2.0.eb

easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.1-GCCcore-13.2.0.eb

diff --git a/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.1-GCCcore-13.2.0.eb b/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.2-GCCcore-13.3.0.eb
index 371a8d85ee..97f475d94c 100644
--- a/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.1-GCCcore-13.2.0.eb
+++ b/easybuild/easyconfigs/s/SlurmViewer/SlurmViewer-1.0.2-GCCcore-13.3.0.eb
@@ -1,23 +1,28 @@
+# #
+# Authors:    
+#  - Patrick de Koning <[email protected]>
+#  - Prerak Mody <[email protected]>
+# #
 easyblock = 'PythonBundle'
 
 name = 'SlurmViewer'
-version = '1.0.1'
+version = '1.0.2'
 
 homepage = 'https://gitlab.com/lkeb/slurm_viewer'
-description = """View the status of a Slurm cluster, including nodes and queue."""
+description = """One-stop command to view the status of a Slurm cluster, including nodes, jobs and resource utilization"""
 
-toolchain = {'name': 'GCCcore', 'version': '13.2.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
 builddependencies = [
-    ('binutils', '2.40'),
-    ('hatchling', '1.18.0'),
-    ('poetry', '1.6.1'),
+    ('binutils', '2.42'),
+    ('hatchling', '1.24.2'),
+    ('poetry', '1.8.3'),
 ]
 
 dependencies = [
-    ('Python', '3.11.5'),
-    ('Python-bundle-PyPI', '2023.10'),
-    ('pydantic', '2.7.4'),
+    ('Python', '3.12.3'),
+    ('Python-bundle-PyPI', '2024.06'),
+    ('pydantic', '2.9.1'),
 ]
 
 use_pip = True
@@ -38,19 +43,19 @@ exts_list = [
     }),
     ('slurm-viewer', version, {
         'source_tmpl': 'slurm_viewer-%(version)s-py3-none-any.whl',
-        'checksums': ['2e42662881458701a09770a52062cb065527e30a39aac35165056f4ccf288f52'],
+        'checksums': ['00baa6a9b26b36592e361486d58df3d68a8df970dfc66ebc2ba7cdd67994bfe0'],
     }),
 ]
 
 sanity_check_paths = {
-    'files': ['bin/slurm-viewer', 'bin/slurm-viewer-init'],
+    'files': ['bin/slurm-viewer'],
     'dirs': ['lib']
 }
 
 sanity_pip_check = True
 
-modloadmsg = """Slurm Viewer requires a configuration file.
-You can make a default settings file in your home directory by running slurm-viewer-init,
-or you can point to a settings file by setting the environment variable $SLURM_VIEW_CONFIG."""
+modloadmsg = """Slurm Viewer uses a configuration file.
+This is made by default (from v1.0.2) in the ~/.config/slurm-viewer/ directory.
+You can also point to a settings file by setting the environment variable $SLURM_VIEW_CONFIG."""
 
 moduleclass = 'tools'

@prerakmody
Copy link
Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@prerakmody: I noticed your comment, but I only dance when @akesandgren or @bartoldeman or @bedroge or @boegel or @branfosj or @casparvl or @jfgrimm or @lexming or @Micket or @migueldiascosta or @ocaisa or @SebastianAchilles or @smoors or @verdurin or @robert-mijakovic or @deniskristak or @ItIsI-Orient or @PetrKralCZ or @sassy-crick or @laraPPr or @pavelToman or @Louwrensth or @Thyre tells me (for now), I'm sorry...

- notification for comment with ID 2548742892 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@robert-mijakovic
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@robert-mijakovic: Request for testing this PR well received on login1

PR test command 'EB_PR=22045 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22045 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14880

Test results coming soon (I hope)...

- notification for comment with ID 2548754159 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge bedroge changed the title Added SlurmViewer-1.0.2 {tools}[GCCcore/13.3.0] SlurmViewer v1.0.2 Dec 17, 2024
homepage = 'https://gitlab.com/lkeb/slurm_viewer'
description = """One-stop command to view the status of a Slurm cluster, including nodes, jobs and resource utilization"""

toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you've bumped the toolchain to GCC 13.3.0 here, you will also have to bump the versions of the dependencies. Not sure if we have all of them for this toolchain, let me check...

Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggested changes bump all dependencies to a version that uses the same toolchain/compiler. I haven't checked if these versions are compatible with your Slurm-Viewer requirements, though.


builddependencies = [
('binutils', '2.40'),
('hatchling', '1.18.0'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
('hatchling', '1.18.0'),
('hatchling', '1.24.2),

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants