Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Score-P configure when install paths contains 'yes/no' #21923

Conversation

Flamefire
Copy link
Contributor

(created using eb --new-pr)

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 4.9.4 milestone Nov 28, 2024
@Micket Micket added the bug fix label Nov 28, 2024
@Micket
Copy link
Contributor

Micket commented Nov 28, 2024

@boegelbot please test @ generoso
EB_ARGS="Score-P-8.4-gompi-2024a.eb"

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=21923 EB_ARGS="Score-P-8.4-gompi-2024a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21923 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14774

Test results coming soon (I hope)...

- notification for comment with ID 2506170314 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5d72b79601e20e5e1dedd7d7446ac660 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @boegelbot FAILED Build succeeded for 0 out of 2 (1 easyconfigs in total) cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8 See https://gist.github.com/boegelbot/5d72b79601e20e5e1dedd7d7446ac660 for a full test report.

Sources for PDT are missing

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 30 out of 33 (13 easyconfigs in total)
i7025 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/d85da477818c718dad39f3a9eae9b21d for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Nov 28, 2024

@Flamefire it looks like this is fixing the same issue as easybuilders/easybuild-easyblocks#3496?

@Flamefire
Copy link
Contributor Author

@Flamefire it looks like this is fixing the same issue as easybuilders/easybuild-easyblocks#3496?

Indeed, haven't seen that you ran into this before. Given the number of files requiring this patch it might make sense to use the easyblock

@Flamefire Flamefire closed this Nov 29, 2024
@Flamefire Flamefire deleted the 20241128142523_new_pr_Score-P80 branch November 29, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants