Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{tools}[GCCcore/13.3.0] GLPK v5.0 #21905

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

branfosj
Copy link
Member

(created using eb --new-pr)

Copy link

github-actions bot commented Nov 24, 2024

Updated software GLPK-5.0-GCCcore-13.3.0.eb

Diff against GLPK-5.0-GCCcore-13.2.0.eb

easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.2.0.eb

diff --git a/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.2.0.eb b/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.3.0.eb
index b14dcd3409..ad96183a02 100644
--- a/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.2.0.eb
+++ b/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.3.0.eb
@@ -10,14 +10,14 @@ description = """The GLPK (GNU Linear Programming Kit) package is intended for
  It is a set of routines written in ANSI C
  and organized in the form of a callable library."""
 
-toolchain = {'name': 'GCCcore', 'version': '13.2.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
 source_urls = [GNU_SOURCE]
 sources = [SOURCELOWER_TAR_GZ]
 checksums = ['4a1013eebb50f728fc601bdd833b0b2870333c3b3e5a816eeba921d95bec6f15']
 
 builddependencies = [
-    ('binutils', '2.40'),
+    ('binutils', '2.42'),
 ]
 dependencies = [
     ('GMP', '6.3.0'),
Diff against GLPK-5.0-GCCcore-12.3.0.eb

easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-12.3.0.eb

diff --git a/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-12.3.0.eb b/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.3.0.eb
index 16cc2ff079..ad96183a02 100644
--- a/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-12.3.0.eb
+++ b/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.3.0.eb
@@ -10,17 +10,17 @@ description = """The GLPK (GNU Linear Programming Kit) package is intended for
  It is a set of routines written in ANSI C
  and organized in the form of a callable library."""
 
-toolchain = {'name': 'GCCcore', 'version': '12.3.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
 source_urls = [GNU_SOURCE]
 sources = [SOURCELOWER_TAR_GZ]
 checksums = ['4a1013eebb50f728fc601bdd833b0b2870333c3b3e5a816eeba921d95bec6f15']
 
 builddependencies = [
-    ('binutils', '2.40'),
+    ('binutils', '2.42'),
 ]
 dependencies = [
-    ('GMP', '6.2.1'),
+    ('GMP', '6.3.0'),
 ]
 
 configopts = '--with-gmp'
Diff against GLPK-5.0-GCCcore-12.2.0.eb

easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-12.2.0.eb

diff --git a/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-12.2.0.eb b/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.3.0.eb
index 226f44dc49..ad96183a02 100644
--- a/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-12.2.0.eb
+++ b/easybuild/easyconfigs/g/GLPK/GLPK-5.0-GCCcore-13.3.0.eb
@@ -10,22 +10,27 @@ description = """The GLPK (GNU Linear Programming Kit) package is intended for
  It is a set of routines written in ANSI C
  and organized in the form of a callable library."""
 
-toolchain = {'name': 'GCCcore', 'version': '12.2.0'}
+toolchain = {'name': 'GCCcore', 'version': '13.3.0'}
 
 source_urls = [GNU_SOURCE]
 sources = [SOURCELOWER_TAR_GZ]
 checksums = ['4a1013eebb50f728fc601bdd833b0b2870333c3b3e5a816eeba921d95bec6f15']
 
-builddependencies = [('binutils', '2.39')]
+builddependencies = [
+    ('binutils', '2.42'),
+]
+dependencies = [
+    ('GMP', '6.3.0'),
+]
 
-dependencies = [('GMP', '6.2.1')]
+configopts = '--with-gmp'
 
-configopts = "--with-gmp"
 
 sanity_check_paths = {
-    'files': ['bin/glpsol', 'include/glpk.h'] +
-             ['lib/libglpk.%s' % x for x in [SHLIB_EXT, 'a']],
+    'files': ['bin/glpsol', 'include/%(namelower)s.h', 'lib/libglpk.a', 'lib/libglpk.%s' % SHLIB_EXT],
     'dirs': [],
 }
 
+sanity_check_commands = ["glpsol --help"]
+
 moduleclass = 'tools'

@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen3

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0210u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8480CL (sapphirerapids), Python 3.6.8
See https://gist.github.com/branfosj/913ba8acf7806f3cf0064ebd52b9b042 for a full test report.

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21905 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21905 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5336

Test results coming soon (I hope)...

- notification for comment with ID 2495970428 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/265c1e67cde67a86e6d45831673c437b for a full test report.

@branfosj
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=21905 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21905 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14763

Test results coming soon (I hope)...

- notification for comment with ID 2495971600 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0e808bbecc1fbe26c9f7a364248b32fb for a full test report.

Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Nov 26, 2024

Going in, thanks @branfosj!

@smoors smoors merged commit ac5b5b0 into easybuilders:develop Nov 26, 2024
10 checks passed
@branfosj branfosj deleted the 20241124121008_new_pr_GLPK50 branch November 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants