Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incompatible types errors when building the R extension dbarts on Arm #20238

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Mar 28, 2024

See vdorie/dbarts#66. We've run into this with EESSI for versions R-bundle-CRAN-2023.12-foss-2023a.eb and R-4.2.2-foss-2022b.eb, but I've also applied the fix to the other R 4.2.x versions.

@bedroge bedroge added bug fix EESSI Related to EESSI project aarch64 Related to Arm 64-bit (aarch64) labels Mar 28, 2024
@boegel boegel added this to the release after 4.9.0 milestone Mar 28, 2024
@boegel
Copy link
Member

boegel commented Mar 28, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr20238"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20238 EB_ARGS="--installpath /tmp/$USER/pr20238" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20238 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3875

Test results coming soon (I hope)...

- notification for comment with ID 2024873682 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge
Copy link
Contributor Author

bedroge commented Mar 28, 2024

Build succeeded on Arm Neoverse v1: EESSI/software-layer#452 (comment)

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/da536d8e90232614b7d361104f014610 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 30, 2024

Going in, thanks @bedroge!

@boegel boegel merged commit 5b04df1 into easybuilders:develop Mar 30, 2024
9 checks passed
@bedroge bedroge deleted the fix_dbarts_aarch64 branch March 30, 2024 06:46
@migueldiascosta
Copy link
Member

Test report by @migueldiascosta
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
gracehopper - Linux Rocky Linux 9.3, AArch64, ARM UNKNOWN (neoverse_v2), 1 x NVIDIA NVIDIA GH200 480GB, 550.54.15, Python 3.9.18
See https://gist.github.com/migueldiascosta/2d0b51938c75f694f33ff1ed5d79ba54 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to Arm 64-bit (aarch64) bug fix EESSI Related to EESSI project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants