Skip to content

Commit

Permalink
Merge pull request #16665 from lexming/20221116171112_new_pr_IJulia1233
Browse files Browse the repository at this point in the history
switch IJulia and MultilevelEstimators to JuliaBundle easyblock
  • Loading branch information
boegel authored Nov 25, 2022
2 parents 0248e8a + 1218b03 commit 254c8c6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 31 deletions.
14 changes: 1 addition & 13 deletions easybuild/easyconfigs/i/IJulia/IJulia-1.23.3-Julia-1.6.7.eb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
easyblock = 'Bundle'
easyblock = 'JuliaBundle'

name = 'IJulia'
version = '1.23.3'
Expand All @@ -14,12 +14,6 @@ dependencies = [
('Julia', _julia_ver, '-linux-%s' % ARCH, SYSTEM),
]

exts_defaultclass = 'JuliaPackage'
exts_filter = ("julia -e 'using %(ext_name)s'", "")
exts_default_options = {
'sources': [{'download_filename': 'v%(version)s.tar.gz', 'filename': SOURCE_TAR_GZ}],
}

exts_list = [
('Parsers', '2.4.2', {
'source_urls': ['https://github.com/JuliaData/Parsers.jl/archive/'],
Expand Down Expand Up @@ -74,13 +68,7 @@ exts_list = [
}),
]

sanity_check_paths = {
'files': [],
'dirs': ['packages'],
}

modextrapaths = {
'JULIA_DEPOT_PATH': '',
'JUPYTER_PATH': 'jupyter',
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
easyblock = 'Bundle'
easyblock = 'JuliaBundle'

name = 'MultilevelEstimators'
version = '0.1.0'
Expand All @@ -15,12 +15,6 @@ dependencies = [
('Julia', local_julia_ver, '-linux-%s' % ARCH, SYSTEM),
]

exts_defaultclass = 'JuliaPackage'
exts_filter = ("julia -e 'using %(ext_name)s'", "")
exts_default_options = {
'sources': [{'download_filename': 'v%(version)s.tar.gz', 'filename': SOURCE_TAR_GZ}],
}

exts_list = [
('Preferences', '1.3.0', {
'source_urls': ['https://github.com/JuliaPackaging/Preferences.jl/archive/'],
Expand Down Expand Up @@ -101,13 +95,4 @@ exts_list = [
}),
]

sanity_check_paths = {
'files': [],
'dirs': ['packages/%(name)s']
}

modextrapaths = {
'JULIA_DEPOT_PATH': '',
}

moduleclass = 'lib'
4 changes: 2 additions & 2 deletions test/easyconfigs/easyconfigs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1092,9 +1092,9 @@ def test_pr_sanity_check_paths(self):
"""Make sure a custom sanity_check_paths value is specified for easyconfigs that use a generic easyblock."""

# some generic easyblocks already have a decent customised sanity_check_paths,
# including CMakePythonPackage, GoPackage, PythonBundle & PythonPackage;
# including CMakePythonPackage, GoPackage, JuliaBundle, PythonBundle & PythonPackage;
# BuildEnv, ModuleRC and Toolchain easyblocks doesn't install anything so there is nothing to check.
whitelist = ['BuildEnv', 'CMakePythonPackage', 'CrayToolchain', 'GoPackage', 'ModuleRC',
whitelist = ['BuildEnv', 'CMakePythonPackage', 'CrayToolchain', 'GoPackage', 'JuliaBundle', 'ModuleRC',
'PythonBundle', 'PythonPackage', 'Toolchain']
# Bundles of dependencies without files of their own
# Autotools: Autoconf + Automake + libtool, (recent) GCC: GCCcore + binutils, CUDA: GCC + CUDAcore,
Expand Down

0 comments on commit 254c8c6

Please sign in to comment.