Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oneAPI sanity check for ifort removal in 2025.0 and newer #3495

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix oneAPI sanity check for ifort removal in 2025.0 and newer #3495

merged 1 commit into from
Nov 6, 2024

Conversation

Thyre
Copy link
Contributor

@Thyre Thyre commented Oct 28, 2024

oneAPI 2025.0.0 removes ifort from the Fortran compiler package. Since this causes the sanity check to fail, update the sanity check to not check ifort anymore starting with LooseVersion('2025').

Related PR: easybuilders/easybuild-easyconfigs#21755

@Thyre Thyre mentioned this pull request Oct 28, 2024
Merged
@Thyre
Copy link
Contributor Author

Thyre commented Oct 28, 2024

See easybuilders/easybuild-easyconfigs#21755 (comment) for a test build.

@Thyre Thyre force-pushed the intel-oneapi-2025-removal-of-ifort branch from 5800e43 to 9c4fa5e Compare October 28, 2024 17:12
@Thyre
Copy link
Contributor Author

Thyre commented Oct 28, 2024

Test report by @Thyre

Overview of tested easyconfigs (in order)

  • SUCCESS intel-compilers-2024.0.0.eb
  • SUCCESS intel-compilers-2023.2.1.eb
  • SUCCESS intel-compilers-2024.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
Linux - Linux EndeavourOS UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 565.57.01, Python 3.12.7
See https://gist.github.com/Thyre/850db8c89a9dc8496739f34075d62f99 for a full test report.

@Thyre
Copy link
Contributor Author

Thyre commented Oct 28, 2024

Test report by @Thyre

Overview of tested easyconfigs (in order)

  • SUCCESS intel-compilers-2024.0.0.eb
  • SUCCESS intel-compilers-2023.2.1.eb
  • SUCCESS intel-compilers-2024.2.0.eb

Build succeeded for 3 out of 3 (3 easyconfigs in total)
datenlager - Linux Ubuntu 24.04, x86_64, AMD Ryzen 7 3700X 8-Core Processor, Python 3.12.3
See https://gist.github.com/Thyre/00bd255d87c2d7e20309ddc2e980aa92 for a full test report.

@Thyre Thyre mentioned this pull request Oct 31, 2024
Open
4 tasks
@Thyre
Copy link
Contributor Author

Thyre commented Nov 1, 2024

Additional tests can be found in easybuilders/easybuild-easyconfigs#21582 for intel-compilers-2023.0.0 to the latest version (with CodePlay NVIDIA SYCL plug-in)

boegel
boegel approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the update label Nov 6, 2024
@boegel boegel added this to the release after 4.9.4 milestone Nov 6, 2024
@boegel boegel merged commit 85d4f97 into easybuilders:develop Nov 6, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
release after 4.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Thyre @boegel