Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date filtering of DWD observations #357

Merged
merged 2 commits into from
Feb 22, 2021
Merged

Fix date filtering of DWD observations #357

merged 2 commits into from
Feb 22, 2021

Conversation

gutzbenj
Copy link
Member

fixes #356

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #357 (7fb5d8d) into main (bd0d37b) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   90.12%   90.26%   +0.14%     
==========================================
  Files          53       53              
  Lines        2785     2785              
  Branches      287      287              
==========================================
+ Hits         2510     2514       +4     
+ Misses        217      214       -3     
+ Partials       58       57       -1     
Flag Coverage Δ
unittests 90.26% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wetterdienst/dwd/observations/api.py 88.10% <100.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0d37b...12d4635. Read the comment docs.

@gutzbenj gutzbenj merged commit b1ca9f4 into main Feb 22, 2021
@gutzbenj gutzbenj deleted the date-filtering branch February 22, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various issues after upgrading to 0.14.0, probably related to end_date
1 participant