Adds +INIT and $OS_RELEASE to cache id #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladaionescu
approved these changes
Nov 14, 2023
idodod
reviewed
Nov 14, 2023
Co-authored-by: Vlad A. Ionescu <[email protected]>
xv-ian-c
reviewed
Nov 14, 2023
| ARG OS_RELEASE=$(md5sum /etc/os-release | cut -d ' ' -f 1) | ||
| ARG cache_id="${EARTHLY_TARGET_PROJECT_NO_TAG}#${OS_RELEASE}#earthly-cargo-cache" | ||
| RUN echo "$cache_id">/earthly/cfg/cache_id | ||
| ENV CARGO_HOME_CACHE_ID=$cache_id |
There was a problem hiding this comment.
This is nice as a workaround but can I suggest you consider making this a first class feature of Earthly UDCs. e.g.
IMPORT github.com/earthly/lib/rust AS rust-udc WITH --foo=bar --cache-id=foo
To set some ARG --global declared at the top of the UDC?
There was a problem hiding this comment.
This is a good feature to add for sure Ian, mind creating a ticket for it?
https://github.com/earthly/earthly/issues/new?assignees=&labels=type%3Aproposal&projects=&template=feature-proposal.md&title=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
/etc/os-release) in the cache id default value. This avoids the scenario of reusing the cache entries across potentially incompatibles shared libraries.+INITUDC used for initialize the build environment for the rest UDCs to be invoked.$CARGO_HOME_CACHE_ID