Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Allow running non-cargo commands with caches mounted #19

Closed
wants to merge 1 commit into from

Conversation

ijc
Copy link

@ijc ijc commented Oct 27, 2023

Refactor the innards of CARGO into RUN_WITH_CACHE and use the latter from the former.

CARGO will be more full featured and should be preferred if possible.

Note that this adds set -e which was previously missing from CARGO.

@ijc ijc requested a review from a team as a code owner October 27, 2023 08:47
@CLAassistant
Copy link

CLAassistant commented Oct 27, 2023

CLA assistant check
All committers have signed the CLA.

rust/Earthfile Outdated Show resolved Hide resolved
Copy link
Member

@idelvall idelvall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added suggestion to comment

@ijc ijc force-pushed the rust-run-with-cache branch from 4918868 to 4aae95b Compare October 27, 2023 09:00
Refactor the innards of `CARGO` into `RUN_WITH_CACHE` and use the latter from
the former.

`CARGO` will be more full featured and should be preferred if possible.

Note that this adds `set -e` which was previously missing from `CARGO`.
@ijc ijc force-pushed the rust-run-with-cache branch from 4aae95b to b5547f4 Compare October 27, 2023 09:33
@ijc ijc requested a review from idelvall October 27, 2023 09:40
@ijc
Copy link
Author

ijc commented Nov 7, 2023

Obsoleted by #20

@ijc ijc closed this Nov 7, 2023
@ijc ijc deleted the rust-run-with-cache branch November 7, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants