Manifests shrink when there are fewer chunk references #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous algorithm we were copying all chunks from the previous version to the new manifest (modulo changes in the current session). Now, we only copy the chunks we need to copy. For example, after a `clear` operation, there will be 0 references in the manifest. Most of the commit is moving code around to make it accessible from `distributed_flush`, that is, moving it from the `Repository` impl to free functions. The only important change happens in `distributed_flush`, where instead of starting from all the chunks in the previous manifest, we use the `all_chunks` iterator. A new test verifies manifests shrink when we delete chunks or whole arrays. Implements: #174
mpiannucci
approved these changes
Oct 13, 2024
| pub fn chunks(&self) -> &BTreeMap<(NodeId, ChunkIndices), ChunkPayload> { | ||
| &self.chunks | ||
| } | ||
|
|
||
| pub fn size(&self) -> usize { | ||
| pub fn len(&self) -> usize { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous algorithm we were copying all chunks from the previous version to the new manifest (modulo changes in the current session).
Now, we only copy the chunks we need to copy. For example, after a
clearoperation, there will be 0 references in the manifest.Most of the commit is moving code around to make it accessible from
distributed_flush, that is, moving it from theRepositoryimpl to free functions. The only important change happens indistributed_flush, where instead of starting from all the chunks in the previous manifest, we use theall_chunksiterator.A new test verifies manifests shrink when we delete chunks or whole arrays.
Implements: #174