forked from flyteorg/flyte
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* attempt to bring in IDL change, and add to workflow struct * go sum * changes * spelling * make generate * just use meta * unit tests * wip * wip * make goimports * wip * add comment in config.yaml * Revert local changes Co-authored-by: Haytham AbuelFutuh <[email protected]>
- Loading branch information
1 parent
91e5d0a
commit a2d8a74
Showing
17 changed files
with
328 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package v1alpha1 | ||
|
||
import "github.com/lyft/flyteidl/gen/pb-go/flyteidl/admin" | ||
|
||
// This contains an OutputLocationPrefix. When running against AWS, this should be something of the form | ||
// s3://my-bucket, or s3://my-bucket/ A sharding string will automatically be appended to this prefix before | ||
// handing off to plugins/tasks. Sharding behavior may change in the future. | ||
// Background available at https://github.com/lyft/flyte/issues/211 | ||
type RawOutputDataConfig struct { | ||
*admin.RawOutputDataConfig | ||
} | ||
|
||
func (in *RawOutputDataConfig) DeepCopyInto(out *RawOutputDataConfig) { | ||
*out = *in | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package v1alpha1 | ||
|
||
import ( | ||
"github.com/lyft/flyteidl/gen/pb-go/flyteidl/admin" | ||
"github.com/stretchr/testify/assert" | ||
|
||
"testing" | ||
) | ||
|
||
func TestRawOutputConfig(t *testing.T) { | ||
r := RawOutputDataConfig{&admin.RawOutputDataConfig{ | ||
OutputLocationPrefix: "s3://bucket", | ||
}} | ||
assert.Equal(t, "s3://bucket", r.OutputLocationPrefix) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
pkg/apis/flyteworkflow/v1alpha1/mocks/ExecutableWorkflow.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
32 changes: 32 additions & 0 deletions
32
pkg/controller/executors/mocks/immutable_execution_context.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.