types(vest): add more method overloads to SuiteSelectors type

[vonagam]

Q	A
Types added?	✔/✖

Just small improvement for getError, getWarning, getErrors, getWarnings, getErrorsByGroup and getWarningsByGroup.

All three variants - without argument / with required argument / with optional optional - need to be provided to cover all possible cases.

If only one provided - an optional argument (like in getError/getWarning) - then a result is not as specific as it could be: getError() without an argument should not say that the result can be a string and getError("field") cannot include an object in its result.

If only two provided - without and with required (like in rest of listed funcs) - then typescript forbids to call a function with an undefined, so getWarnings(variable) is treated as wrong if variable can be undefined even though the code can handle it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 8, 2023 3:21am
vest-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 8, 2023 3:21am

[ealush]

Hm. let me go over it. I did not experience it, and I am worried this will change the behavior of the overloads. I'll run a few tests

[vonagam]

Here is a simple demonstration in typescript playground.

[ealush]

Thanks @vonagam! Ran a couple of tests and this looks good 👍

[ealush]

Released in 5.0.4