Fix all failing tests

packages/n4s/src/plugins/schema/__tests__/shape&loose.test.ts

@@ -14,7 +14,7 @@ describe.each(['loose', 'shape'])('enforce.%s', (methodName: string) => {
         enforce[methodName]({
           username: enforce.isString(),
           age: enforce.isNumber().gt(18),
-        }).run({ username: 'ealush', age: 31 })
+        }).run({ username: 'ealush', age: 31 }),
       ).toEqual(ruleReturn.passing());
     });
 
@@ -23,7 +23,7 @@ describe.each(['loose', 'shape'])('enforce.%s', (methodName: string) => {
         enforce[methodName]({
           username: enforce.isString(),
           age: enforce.isNumber().gt(18),
-        }).run({ username: null, age: 0 })
+        }).run({ username: null, age: 0 }),
       ).toEqual(ruleReturn.failing());
     });
 
@@ -48,7 +48,7 @@ describe.each(['loose', 'shape'])('enforce.%s', (methodName: string) => {
               state: 'NY',
               zip: 12345,
             },
-          })
+          }),
         ).toEqual(ruleReturn.passing());
       });
       it('Should return a failing return when tests are invalid', () => {
@@ -69,7 +69,7 @@ describe.each(['loose', 'shape'])('enforce.%s', (methodName: string) => {
               street: '123 Main St',
               city: null,
             },
-          })
+          }),
         ).toEqual(ruleReturn.failing());
       });
     });

packages/vest/src/core/VestBus/VestBus.ts

@@ -1,4 +1,3 @@
-import { SuiteWalker } from 'SuiteWalker';
 import { CB, ValueOf } from 'vest-utils';
 import { Bus, RuntimeEvents, TIsolate } from 'vestjs-runtime';
 
@@ -11,6 +10,7 @@ import {
   useResetSuite,
 } from 'Runtime';
 import { TFieldName } from 'SuiteResultTypes';
+import { SuiteWalker } from 'SuiteWalker';
 import { TestWalker } from 'TestWalker';
 import { VestTest } from 'VestTest';
 import { useOmitOptionalFields } from 'omitOptionalFields';

packages/vest/src/core/__tests__/runtime.test.ts

@@ -65,6 +65,7 @@ describe('useLoadSuite', () => {
 
 function genDump() {
   const suite = vest.create(() => {
+    vest.mode(vest.Modes.ALL);
     vest.skip('t5');
 
     vest.test('t1', () => false);

packages/vest/src/hooks/focused/useIsExcluded.ts

@@ -10,7 +10,7 @@ import { useHasOnliedTests } from 'useHasOnliedTests';
 //Checks whether a certain test profile excluded by any of the exclusion groups.
 
 function useClosestMatchingFocus(
-  testObject: TIsolateTest
+  testObject: TIsolateTest,
 ): Nullable<TIsolateFocused> {
   return Walker.findClosest(testObject, (child: TIsolate) => {
     if (!FocusSelectors.isIsolateFocused(child)) return false;
@@ -21,7 +21,6 @@ function useClosestMatchingFocus(
   });
 }
 
-// eslint-disable-next-line complexity, max-statements
 export function useIsExcluded(testObject: TIsolateTest): boolean {
   const { fieldName } = VestTest.getData(testObject);
 

packages/vest/src/suiteResult/selectors/__tests__/hasFailuresByTestObject.test.ts

@@ -1,8 +1,8 @@
 import { faker } from '@faker-js/faker';
-import { VestTest } from 'VestTest';
 
 import { TIsolateTest } from 'IsolateTest';
 import { Severity } from 'Severity';
+import { VestTest } from 'VestTest';
 import { hasFailuresByTestObject } from 'hasFailuresByTestObjects';
 import { mockIsolateTest } from 'vestMocks';
 
@@ -22,10 +22,10 @@ describe('hasFailuresByTestObject', () => {
     it('Should return false', () => {
       expect(hasFailuresByTestObject(testObject, Severity.ERRORS)).toBe(false);
       expect(hasFailuresByTestObject(testObject, Severity.WARNINGS)).toBe(
-        false
+        false,
       );
       expect(
-        hasFailuresByTestObject(testObject, Severity.ERRORS, fieldName)
+        hasFailuresByTestObject(testObject, Severity.ERRORS, fieldName),
       ).toBe(false);
     });
   });
@@ -38,23 +38,23 @@ describe('hasFailuresByTestObject', () => {
       describe('When non matching severity profile', () => {
         it('should return false', () => {
           expect(hasFailuresByTestObject(testObject, Severity.WARNINGS)).toBe(
-            false
+            false,
           );
           VestTest.warn(testObject);
           expect(hasFailuresByTestObject(testObject, Severity.ERRORS)).toBe(
-            false
+            false,
           );
         });
       });
 
       describe('When matching severity profile', () => {
         it('Should return true', () => {
           expect(hasFailuresByTestObject(testObject, Severity.ERRORS)).toBe(
-            true
+            true,
           );
           VestTest.warn(testObject);
           expect(hasFailuresByTestObject(testObject, Severity.WARNINGS)).toBe(
-            true
+            true,
           );
         });
       });
@@ -63,23 +63,27 @@ describe('hasFailuresByTestObject', () => {
       describe('When field name matches', () => {
         it('should return false', () => {
           expect(
-            hasFailuresByTestObject(testObject, Severity.ERRORS, 'non_matching')
+            hasFailuresByTestObject(
+              testObject,
+              Severity.ERRORS,
+              'non_matching',
+            ),
           ).toBe(false);
         });
       });
 
       describe('When field name matches', () => {
         it('Should continue with normal flow', () => {
           expect(hasFailuresByTestObject(testObject, Severity.WARNINGS)).toBe(
-            false
+            false,
           );
           VestTest.warn(testObject);
           expect(hasFailuresByTestObject(testObject, Severity.ERRORS)).toBe(
-            false
+            false,
           );
           VestTest.fail(testObject);
           expect(hasFailuresByTestObject(testObject, Severity.WARNINGS)).toBe(
-            true
+            true,
           );
         });
       });

packages/vest/src/suiteResult/selectors/__tests__/summaryFailures.test.ts

@@ -1,4 +1,5 @@
 import { TTestSuite } from 'testUtils/TVestMock';
+
 import * as vest from 'vest';
 
 describe('summaryFailures', () => {
@@ -68,6 +69,7 @@ describe('summaryFailures', () => {
 
     test('Should add the test group into the error object', () => {
       suite = vest.create(() => {
+        vest.mode(vest.Modes.ALL);
         vest.group('user', () => {
           vest.test('username', 'uxsername is required', () => false);
           vest.test('username', 'username is too short', () => false);

packages/vest/src/suiteResult/selectors/shouldAddValidProperty.ts

@@ -1,4 +1,3 @@
-import { SuiteWalker } from 'SuiteWalker';
 import { useIsOptionalFieldApplied } from 'optional';
 import { Predicates } from 'vest-utils';
 import { VestRuntime } from 'vestjs-runtime';
@@ -8,6 +7,7 @@ import { TIsolateTest } from 'IsolateTest';
 import { OptionalFieldTypes } from 'OptionalTypes';
 import { Severity } from 'Severity';
 import { TFieldName, TGroupName } from 'SuiteResultTypes';
+import { SuiteWalker } from 'SuiteWalker';
 import { TestWalker } from 'TestWalker';
 import { VestTest } from 'VestTest';
 import {

packages/vest/src/vest.ts

@@ -1,7 +1,6 @@
 import { enforce } from 'n4s';
-
-// eslint-disable-next-line import/order -- will handle this circular dep issue later.
 import { optional } from 'optional';
+
 import { Modes } from 'Modes';
 import type {
   SuiteResult,

packages/vestjs-runtime/src/Isolate/Isolate.ts

@@ -29,7 +29,6 @@ type UsedFeaturesOnly<P extends IsolatePayload> = Pick<
 >;
 
 export class Isolate {
-  // eslint-disable-next-line max-statements
   static create<Payload extends IsolatePayload>(
     type: string,
     callback: CB,
@@ -49,15 +48,11 @@ export class Isolate {
 
     const shouldRunNew = Object.is(nextIsolateChild, newCreatedNode);
 
-    let output: any;
-
     VestRuntime.addNodeToHistory(nextIsolateChild);
 
-    if (shouldRunNew) {
-      output = useRunAsNew(localHistoryNode, newCreatedNode, callback);
-    } else {
-      output = nextIsolateChild.output;
-    }
+    const output = shouldRunNew
+      ? useRunAsNew(localHistoryNode, newCreatedNode, callback)
+      : nextIsolateChild.output;
 
     IsolateMutator.saveOutput(nextIsolateChild, output);
 

packages/vestjs-runtime/src/IsolateWalker.ts

@@ -9,7 +9,7 @@ type VisitOnlyPredicate = (isolate: TIsolate) => boolean;
 export function walk(
   startNode: TIsolate,
   callback: (isolate: TIsolate, breakout: CB<void>) => void,
-  visitOnly?: VisitOnlyPredicate
+  visitOnly?: VisitOnlyPredicate,
 ): void {
   // If the startNode has no children, there is nothing to walk.
   if (isNullish(startNode.children)) {
@@ -43,7 +43,7 @@ export function walk(
           breakout();
         });
       },
-      visitOnly
+      visitOnly,
     );
   }
 
@@ -57,7 +57,7 @@ export function walk(
 export function some(
   startNode: TIsolate,
   predicate: (node: TIsolate) => boolean,
-  visitOnly?: VisitOnlyPredicate
+  visitOnly?: VisitOnlyPredicate,
 ): boolean {
   let hasMatch = false;
 
@@ -70,7 +70,7 @@ export function some(
         hasMatch = true;
       }
     },
-    visitOnly
+    visitOnly,
   );
 
   return hasMatch;
@@ -86,7 +86,7 @@ export function has(startNode: TIsolate, match: VisitOnlyPredicate): boolean {
 // and returns the first direct descendant that satisfies the predicate
 export function findClosest<I extends TIsolate = TIsolate>(
   startNode: TIsolate,
-  predicate: (node: TIsolate) => boolean
+  predicate: (node: TIsolate) => boolean,
 ): Nullable<I> {
   let found: Nullable<TIsolate> = null;
   let current: Nullable<TIsolate> = startNode;
@@ -109,7 +109,7 @@ export function findClosest<I extends TIsolate = TIsolate>(
 export function find(
   startNode: TIsolate,
   predicate: (node: TIsolate) => boolean,
-  visitOnly?: VisitOnlyPredicate
+  visitOnly?: VisitOnlyPredicate,
 ): Nullable<TIsolate> {
   let found = null;
 
@@ -122,7 +122,7 @@ export function find(
         found = node;
       }
     },
-    visitOnly
+    visitOnly,
   );
 
   return found;
@@ -133,7 +133,7 @@ export function find(
 export function every(
   startNode: TIsolate,
   predicate: (node: TIsolate) => boolean,
-  visitOnly?: VisitOnlyPredicate
+  visitOnly?: VisitOnlyPredicate,
 ): boolean {
   let hasMatch = true;
   walk(
@@ -144,7 +144,7 @@ export function every(
         hasMatch = false;
       }
     },
-    visitOnly
+    visitOnly,
   );
 
   return hasMatch;
@@ -156,7 +156,7 @@ export function every(
 export function pluck(
   startNode: TIsolate,
   predicate: (node: TIsolate) => boolean,
-  visitOnly?: VisitOnlyPredicate
+  visitOnly?: VisitOnlyPredicate,
 ): void {
   walk(
     startNode,
@@ -165,15 +165,15 @@ export function pluck(
         IsolateMutator.removeChild(node.parent, node);
       }
     },
-    visitOnly
+    visitOnly,
   );
 }
 
 // Returns the closest ancestor Isolate object of the given
 //startNode that satisfies the given predicate function.
 export function closest(
   startNode: TIsolate,
-  predicate: (node: TIsolate) => boolean
+  predicate: (node: TIsolate) => boolean,
 ): Nullable<TIsolate> {
   let current: Nullable<TIsolate> = startNode;
   do {
@@ -189,7 +189,7 @@ export function closest(
 // given startNode that satisfies the given predicate function exists.
 export function closestExists(
   startNode: TIsolate,
-  predicate: (node: TIsolate) => boolean
+  predicate: (node: TIsolate) => boolean,
 ): boolean {
   return !!closest(startNode, predicate);
 }