Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply correct defaults for username / password #239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DrRataplan
Copy link

@line-o
Copy link
Member

line-o commented Oct 29, 2024

That's @DrRataplan for your contribution. I am just unsure what the best default is here:

  • why use guest/guest? A lot of requests do not need leveraged permissions and will now fail when using the admin account on instances that most likely will have changed the password (eg. xst info).
  • why use admin/(empty)? It's convenient when working with test instances.

@DrRataplan
Copy link
Author

I'm also unsure. I feel something for having leveled permissions: attempt using a guest user if we only need guest-like access, and admin if we require more privileges.
But this increases complexity.

Based on the comments in the file I touched and the README, admin/<empty> was intended to be the default. This used to be the actual behaviour, but that was removed in 508c75f. It's just that the comment and the README was not updated. This caused my (and @JoernT's) confusion.

Do we wanna go left or right?

@line-o
Copy link
Member

line-o commented Nov 3, 2024

@DrRataplan I would like to update the readme with the actual defaults

@line-o
Copy link
Member

line-o commented Nov 3, 2024

maybe together with #240

@DrRataplan
Copy link
Author

I am up for that, especially combined with the dotenv changes: I will then just make a dotenv in the folder that houses all my projects!

Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the readme to reflect the correct defaults instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keep on getting "Package installation failed. User "guest" is not a member of the "dba" group."
2 participants