Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x.x] Handle IllegalStateException in file:directory-list#2 #5093

Merged
merged 4 commits into from
Oct 19, 2023
Merged

[6.x.x] Handle IllegalStateException in file:directory-list#2 #5093

merged 4 commits into from
Oct 19, 2023

Conversation

line-o
Copy link
Member

@line-o line-o commented Oct 16, 2023 •
edited by adamretter
Loading

Backport of #5092

Supersedes #5061

@line-o
[fix] handle IllegalStateException in file:directory-list#2
7926887 
fixes eXist-db#5028

The Java code of DirectoryList can throw an IllegalStateException
when a non-existent directory is supplied as its first argument.
This exception class is now handled in file:list#2.

Additionally, the raised error now has a proper code `file:DIRECTORY_NOT_FOUND`.

This will allow us in the future to add proper error codes to more
errors raised by this module.
@line-o line-o mentioned this pull request Oct 16, 2023
Merged
@line-o line-o requested a review from a team October 16, 2023 22:14
@adamretter adamretter changed the title [6.x.x] Backport #5092 [6.x.x] Handle IllegalStateException in file:directory-list#2 Oct 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

48.6% 48.6% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

adamretter
adamretter approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the code review, now LGTM.

@adamretter adamretter merged commit a1ba17f into eXist-db:develop-6.x.x Oct 19, 2023
7 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dizzzz dizzzz dizzzz approved these changes

@adamretter adamretter adamretter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@line-o @adamretter @dizzzz