Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x.x] Refactor to highlight materialization query execution model #5080

Merged
merged 3 commits into from
Oct 30, 2023
Merged

[6.x.x] Refactor to highlight materialization query execution model #5080

merged 3 commits into from
Oct 30, 2023

Conversation

adamretter
Copy link
Contributor

Backport of #5079

@adamretter adamretter added the enhancement new features, suggestions, etc. label Oct 8, 2023
@adamretter adamretter added this to the eXist-6.2.1 milestone Oct 8, 2023
@adamretter
[refactor] Add a Materializable interface to explicitly mark which ex…
d8cbf43 
…pressions use the Materialization query execution model
@adamretter adamretter force-pushed the 6.x.x/refactor/query-materialization branch from 3818f7a to d8cbf43 Compare October 9, 2023 15:01
dizzzz
dizzzz approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@dizzzz dizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my remarks in other PR

@line-o
Copy link
Member

line-o commented Oct 16, 2023

I would like to understand why this change is necessary to be back ported to 6.x.x. @adamretter what does this add for users of 6.x.x?

@adamretter
Copy link
Contributor Author

what does this add for users of 6.x.x?
@line-o It adds exactly the same facilities as described in #5079

@dizzzz
Copy link
Member

dizzzz commented Oct 30, 2023

IMO it is good to have 6 and 7 branch as equal as possible for the time being

@dizzzz dizzzz merged commit 7830629 into eXist-db:develop-6.x.x Oct 30, 2023
5 of 14 checks passed
@adamretter
Copy link
Contributor Author

Thanks you @dizzzz :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinhapa reinhapa reinhapa approved these changes

@dizzzz dizzzz dizzzz approved these changes

Assignees
No one assigned
Labels
enhancement new features, suggestions, etc.
Projects
None yet
Milestone
eXist-6.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@adamretter @line-o @dizzzz @reinhapa