Add check to see if we have root. Required for sas3ircu binary to work. #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to request this merge to implement a check for root access with this wrapper script.
We use the script solo (as a standalone check) and it give misleading output without root access:
Without root:
$ /usr/bin/check_sas3ircu
-- Controller informations --
-- ID | Model
-- Arrays informations --
-- ID | Type | Size | Status
-- Disks informations
-- ID | Model | Status
$ /usr/bin/check_sas3ircu --nagios
RAID OK - Arrays: OK:0 Bad:0 - Disks: OK:0 Bad:0
$ echo $?
0
As you can see, no controller details, but the check returns exit 0. Also, Arrays and disks are both 0. A quick and easy fix is to add a check for root access.