Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ones() and ones_like() with tests. #64

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

ameya98
Copy link
Collaborator

@ameya98 ameya98 commented Jan 5, 2024

I got tired of writing this again and again xD also numpy and jax.numpy have the same functions.

@mariogeiger
Copy link
Member

mariogeiger commented Jan 5, 2024

Thanks Ameya, I merge. But just want to mention that there was a reason why I didn't provide those functions. They are simply not equivariant.

Maybe we could later add a warning when called with anything else than 0e and warn the user of the danger of making something non equivariant.

@mariogeiger mariogeiger merged commit e0753a8 into e3nn:main Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants